Skip to content

[Webpack Encore] Fixed code display #10645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Webpack Encore] Fixed code display #10645

wants to merge 1 commit into from

Conversation

jmsche
Copy link
Contributor

@jmsche jmsche commented Nov 7, 2018

Hi, this PR fixes an issue that renders an empty code block :)

@javiereguiluz javiereguiluz added this to the 4.1 milestone Nov 8, 2018
@javiereguiluz javiereguiluz modified the milestones: 4.1, 3.4 Nov 8, 2018
@javiereguiluz
Copy link
Member

@jmsche very nice catch! Thanks for fixing it (we merged it in 3.4 branch). Also, congrats on your first Symfony Docs contribution!

javiereguiluz added a commit that referenced this pull request Nov 8, 2018
@javiereguiluz
minor #10645 [Webpack Encore] Fixed code display (jmsche)
dfc4782 
This PR was submitted for the 4.1 branch but it was merged into the 3.4 branch instead (closes #10645).

Discussion
----------

[Webpack Encore] Fixed code display

Hi, this PR fixes an issue that renders an empty code block :)

Commits
-------

c58cd7a [Webpack Encore] Fixed code display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunicmarko20 kunicmarko20 kunicmarko20 approved these changes

@royklutman royklutman royklutman approved these changes

Assignees
No one assigned
Labels
front-end Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@jmsche @javiereguiluz @kunicmarko20 @royklutman @carsonbot